Advance Debugging #5774

akosyakov · 2019-07-22T14:59:27Z

What it does

watch expression support #5769 - watch expressions
- a CQ for add icon: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20445 (resolved)
exception breakpoints support #5768 - exception breakpoints
function breakpoints support #5767 - function breakpoints
- a CQ for function breakpoint icon: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20470
[debug] inline breakpoints support #3807 - inlined breakpoints
identity of breakpoints are not preserved by plugins #5788 - fix identify of breakpoints in the plugin process
add copyrights to all copied icons

Pause on an exception with watch expressions:

How to test

watch expressions: add watch expressions and start debugging, they should be updated as you go
exception breakpoints:
- they are provided by a debug adapter on the first run, so start debugging something
- after that you can enable them
- after the debug session is finished, such breakpoints should be preserved anyway and reevaluated on next run
- when exception breakpoint hits you should be able to see the reason in an editor
function breakpoints:
- install nodejs vscode extensions, https://marketplace.visualstudio.com/items?itemName=ms-vscode.node-debug2 and https://marketplace.visualstudio.com/items?itemName=ms-vscode.node-debug
- uninstall native Theia nodejs extension from example app and rebuild it
- follow https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_function-breakpoints
  - it works only with legacy protocol for Node.js < 8 and only for global functions which were already defined at runtime
inlined breakpoints
- look out for regressions with usual breakpoints, one should be able to mix them, disable, enable, edit on the same line via the context menu in the ruler and the breakpoints debug view
breakpoints identity issues in the plugin host process: TBD

packages/core/src/browser/icons/add-inverse.svg

tolusha · 2019-08-27T07:55:21Z

@akosyakov Is it ready for review?

akosyakov · 2019-08-27T08:24:33Z

@tolusha I did not have time to add test sample VS Code extension to test identity of breakpoints in the plugin host process, but the rest should be good.

tolusha · 2019-12-11T12:26:25Z

@akosyakov
I probably won't be able handle this PR starting next week

akosyakov · 2019-12-11T19:29:45Z

@tolusha the problem is that we are going to prohibit to hard code colors in css, only css color variables can be used which are first registered via ColorContribution, i.e. all colors should be themable. This PR introduces such hardcoding.

You can change base of this PR to branch of #6722, introduce new colors and update css to use them. So this PR will be prepared for testing after theming PR is merged. Colors should be registered with ids as in VS Code, i.e. with debugExceptionWidget.background and debugExceptionWidget.border. For default values and descriptions please look up VS Code code base. After registration colors can be referenced in css with var(--theia-debugExceptionWidget-background) and var(--theia-debugExceptionWidget-border).

akosyakov · 2019-12-26T11:24:03Z

I'm going to reset base branch for it as #6722 and add missing colors.

akosyakov · 2019-12-27T11:01:25Z

I've fixed theming, so it should be fine to merge after the theming PR is in.

@thegecko I think all comments except using the context menu to add inline breakpoints were fixed. Would it be alright to tackle management of inline breakopints via the context menu separately? Right now one can add it by putting a cursor at some position and using the command palette, the debug top-level menu or the short-cut shift + f9.

@tolusha If you are fine with changes please don't forget to give an approve.

thegecko · 2019-12-27T18:31:11Z

@akosyakov, perhaps open an issue to add the context menu item? Happy to merge as is.

akosyakov · 2019-12-27T19:11:22Z

@thegecko I've filed an issue for inline breakpoints management with the context menu: #6795 I'm going to rebase the PR and if the build is green then merge it.

Signed-off-by: Anton Kosyakov <[email protected]>

- fix #5767 - function breakpoints support - fix #5788 - preserve breakpoints identity in the plugin host process Signed-off-by: Anton Kosyakov <[email protected]>

Signed-off-by: Anton Kosyakov <[email protected]>

Signed-off-by: Anatoliy Bazko <[email protected]>

Signed-off-by: Anton Kosyakov <[email protected]>

changes were addressed: #5774 (comment)

akosyakov added the debug issues that related to debug functionality label Jul 22, 2019

akosyakov force-pushed the ak/advance_debug branch 2 times, most recently from 225056c to 7bae251 Compare July 23, 2019 09:46

akosyakov mentioned this pull request Jul 23, 2019

detect links in debug exception breakpoint widget #5784

Open

akosyakov force-pushed the ak/advance_debug branch from 758c4f0 to 518fc48 Compare July 23, 2019 15:09

akosyakov force-pushed the ak/view_containers_integration branch from 624192b to 3e25344 Compare July 23, 2019 21:30

akosyakov force-pushed the ak/advance_debug branch from 518fc48 to 00bc2b9 Compare July 24, 2019 07:45

akosyakov mentioned this pull request Jul 24, 2019

identity of breakpoints are not preserved by plugins #5788

Closed

akosyakov commented Jul 24, 2019

View reviewed changes

packages/core/src/browser/icons/add-inverse.svg Outdated Show resolved Hide resolved

akosyakov force-pushed the ak/view_containers_integration branch from 3e25344 to 9604944 Compare July 25, 2019 13:02

akosyakov force-pushed the ak/advance_debug branch 4 times, most recently from add7a65 to 5413b27 Compare July 26, 2019 08:12

akosyakov force-pushed the ak/view_containers_integration branch 9 times, most recently from 94c8539 to 80c4e86 Compare August 2, 2019 14:29

akosyakov changed the base branch from ak/view_containers_integration to master August 24, 2019 20:14

akosyakov force-pushed the ak/advance_debug branch from 5413b27 to a0d2d2c Compare August 24, 2019 20:23

akosyakov marked this pull request as ready for review August 27, 2019 07:02

akosyakov requested a review from a team as a code owner August 27, 2019 07:02

akosyakov requested a review from a team August 27, 2019 07:02

akosyakov changed the base branch from master to color_theming December 26, 2019 11:24

akosyakov force-pushed the color_theming branch from aa77210 to 872e810 Compare December 27, 2019 07:47

akosyakov force-pushed the ak/advance_debug branch from c2e5e23 to 96becef Compare December 27, 2019 10:58

tolusha approved these changes Dec 27, 2019

View reviewed changes

akosyakov changed the base branch from color_theming to master December 27, 2019 18:59

akosyakov force-pushed the ak/advance_debug branch from 96becef to 15af855 Compare December 27, 2019 19:02

akosyakov mentioned this pull request Dec 27, 2019

manage inline breakpoints with the editor gutter context menu #6795

Open

akosyakov mentioned this pull request Dec 30, 2019

[theming] changing themes quickly results in a dialog #6786

Closed

akosyakov and others added 12 commits January 1, 2020 18:37

[debug] fix #5769: watch support

c889bca

Signed-off-by: Anton Kosyakov <[email protected]>

[debug] fix #5768: exception breakpoints support

05bd53e

Signed-off-by: Anton Kosyakov <[email protected]>

[debug] added function breakpoints support

eb37b3f

- fix #5767 - function breakpoints support - fix #5788 - preserve breakpoints identity in the plugin host process Signed-off-by: Anton Kosyakov <[email protected]>

[debug] fix ##3807: added inline breakpoints support

e440b34

Signed-off-by: Anton Kosyakov <[email protected]>

Fix after rebasing on master

f58c5af

Signed-off-by: Anatoliy Bazko <[email protected]>

Small fixes

fa35b08

Signed-off-by: Anatoliy Bazko <[email protected]>

Fix debug menu

e3606fc

Signed-off-by: Anatoliy Bazko <[email protected]>

Rename inlineBreakpoint -> getInlineBreakpoint

379c948

Signed-off-by: Anatoliy Bazko <[email protected]>

Add license to icons

e8e3f7b

Signed-off-by: Anatoliy Bazko <[email protected]>

Show Exception widget if topframe doesn't have source

9bbcc4c

Signed-off-by: Anatoliy Bazko <[email protected]>

Add license to all copied icons

2b2e97e

Signed-off-by: Anatoliy Bazko <[email protected]>

[theming] apply debug exception widget colors

43b344d

Signed-off-by: Anton Kosyakov <[email protected]>

akosyakov force-pushed the ak/advance_debug branch from 5bbb526 to 43b344d Compare January 1, 2020 18:37

akosyakov merged commit 3b4b1e5 into master Jan 1, 2020

akosyakov deleted the ak/advance_debug branch January 1, 2020 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advance Debugging #5774

Advance Debugging #5774

akosyakov commented Jul 22, 2019 •

edited

Loading

tolusha commented Aug 27, 2019

akosyakov commented Aug 27, 2019

tolusha commented Dec 11, 2019

akosyakov commented Dec 11, 2019

akosyakov commented Dec 26, 2019

akosyakov commented Dec 27, 2019

thegecko commented Dec 27, 2019

akosyakov commented Dec 27, 2019

Advance Debugging #5774

Advance Debugging #5774

Conversation

akosyakov commented Jul 22, 2019 • edited Loading

What it does

How to test

tolusha commented Aug 27, 2019

akosyakov commented Aug 27, 2019

tolusha commented Dec 11, 2019

akosyakov commented Dec 11, 2019

akosyakov commented Dec 26, 2019

akosyakov commented Dec 27, 2019

thegecko commented Dec 27, 2019

akosyakov commented Dec 27, 2019

akosyakov commented Jul 22, 2019 •

edited

Loading